From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f173.google.com ([209.85.214.173]:35393 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933806AbcCONpw (ORCPT ); Tue, 15 Mar 2016 09:45:52 -0400 Received: by mail-ob0-f173.google.com with SMTP id fp4so17401583obb.2 for ; Tue, 15 Mar 2016 06:45:47 -0700 (PDT) Date: Tue, 15 Mar 2016 08:45:45 -0500 From: Seth Forshee To: Pavel Tikhomirov Cc: Andy Lutomirski , "Eric W. Biederman" , devel@openvz.org, Serge Hallyn , Alexander Viro , linux-security-module@vger.kernel.org, linux-mtd@lists.infradead.org, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org, Konstantin Khorenko , Pavel Emelyanov Subject: Re: [PATCH] fs: remove excess check for in_userns Message-ID: <20160315134545.GB27754@ubuntu-xps13> References: <1451930639-94331-4-git-send-email-seth.forshee@canonical.com> <1458043740-14229-1-git-send-email-ptikhomirov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458043740-14229-1-git-send-email-ptikhomirov@virtuozzo.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Mar 15, 2016 at 03:09:00PM +0300, Pavel Tikhomirov wrote: > If in_userns returns false mnt_may_suid also returns false, and we > will reach second(removed) if-check only in case it does not trigger, > so remove it. We had a somewhat lengthy discussion previously where one of the conclusions was that we'd have that check in both places even though it's redundant. Iirc the reason was that though they're doing the same test they're doing so to answer different questions, so we should have the test in both places (or something along those lines). Thanks, Seth