linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Chris Mason <clm@fb.com>, Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH 0/2] fix RLIMIT_CORE accounting for sparse dumps
Date: Fri, 18 Mar 2016 14:39:23 -0700	[thread overview]
Message-ID: <20160318213923.GA24062@vader.DHCP.TheFacebook.com> (raw)
In-Reply-To: <20160226183108.rhtzztp7dbf5wb34@floor.thefacebook.com>

On Fri, Feb 26, 2016 at 01:31:08PM -0500, Chris Mason wrote:
> On Fri, Feb 26, 2016 at 09:57:22AM -0800, Omar Sandoval wrote:
> > On Thu, Feb 18, 2016 at 04:32:52PM -0800, Omar Sandoval wrote:
> > > From: Omar Sandoval <osandov@fb.com>
> > > 
> > > Hi,
> > > 
> > > Someone here reported that they were getting truncated core dumps even
> > > when RLIMIT_CORE was larger than the physical memory of the machine. It
> > > looks some cleanup patches back in v3.13 [1] changed the behaviour of
> > > the limit to also charge for sparse areas of a file.
> > [snip]
> > > 
> > > Omar Sandoval (2):
> > >   coredump: get rid of coredump_params->written
> > >   coredump: only charge written data against RLIMIT_CORE
> > > 
> > >  arch/powerpc/platforms/cell/spufs/coredump.c | 5 +++--
> > >  fs/binfmt_elf.c                              | 2 +-
> > >  fs/binfmt_elf_fdpic.c                        | 2 +-
> > >  fs/coredump.c                                | 7 ++-----
> > >  4 files changed, 7 insertions(+), 9 deletions(-)
> > > 
> > > -- 
> > > 2.7.1
> > > 
> > 
> > Ping, any change this can get in for -rc6?
> 
> Since this isn't a recent regression, I'd wait until the next merge
> window instead of rc6.
> 
> -chris

Al, does this look okay for the merge window?

-- 
Omar

  reply	other threads:[~2016-03-18 21:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19  0:32 [PATCH 0/2] fix RLIMIT_CORE accounting for sparse dumps Omar Sandoval
2016-02-19  0:32 ` [PATCH 1/2] coredump: get rid of coredump_params->written Omar Sandoval
2016-02-19  0:32 ` [PATCH 2/2] coredump: only charge written data against RLIMIT_CORE Omar Sandoval
2016-02-26 17:57 ` [PATCH 0/2] fix RLIMIT_CORE accounting for sparse dumps Omar Sandoval
2016-02-26 17:58   ` Omar Sandoval
2016-02-26 18:31   ` Chris Mason
2016-03-18 21:39     ` Omar Sandoval [this message]
2016-03-26  1:45       ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160318213923.GA24062@vader.DHCP.TheFacebook.com \
    --to=osandov@osandov.com \
    --cc=clm@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).