From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:35847 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932364AbcCRVj0 (ORCPT ); Fri, 18 Mar 2016 17:39:26 -0400 Received: by mail-pf0-f181.google.com with SMTP id u190so183858388pfb.3 for ; Fri, 18 Mar 2016 14:39:25 -0700 (PDT) Date: Fri, 18 Mar 2016 14:39:23 -0700 From: Omar Sandoval To: Chris Mason , Al Viro , linux-fsdevel@vger.kernel.org, Omar Sandoval Subject: Re: [PATCH 0/2] fix RLIMIT_CORE accounting for sparse dumps Message-ID: <20160318213923.GA24062@vader.DHCP.TheFacebook.com> References: <20160226175722.GA10341@vader.DHCP.TheFacebook.com> <20160226183108.rhtzztp7dbf5wb34@floor.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160226183108.rhtzztp7dbf5wb34@floor.thefacebook.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Feb 26, 2016 at 01:31:08PM -0500, Chris Mason wrote: > On Fri, Feb 26, 2016 at 09:57:22AM -0800, Omar Sandoval wrote: > > On Thu, Feb 18, 2016 at 04:32:52PM -0800, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > Hi, > > > > > > Someone here reported that they were getting truncated core dumps even > > > when RLIMIT_CORE was larger than the physical memory of the machine. It > > > looks some cleanup patches back in v3.13 [1] changed the behaviour of > > > the limit to also charge for sparse areas of a file. > > [snip] > > > > > > Omar Sandoval (2): > > > coredump: get rid of coredump_params->written > > > coredump: only charge written data against RLIMIT_CORE > > > > > > arch/powerpc/platforms/cell/spufs/coredump.c | 5 +++-- > > > fs/binfmt_elf.c | 2 +- > > > fs/binfmt_elf_fdpic.c | 2 +- > > > fs/coredump.c | 7 ++----- > > > 4 files changed, 7 insertions(+), 9 deletions(-) > > > > > > -- > > > 2.7.1 > > > > > > > Ping, any change this can get in for -rc6? > > Since this isn't a recent regression, I'd wait until the next merge > window instead of rc6. > > -chris Al, does this look okay for the merge window? -- Omar