From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:39968 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754426AbcCUMRb (ORCPT ); Mon, 21 Mar 2016 08:17:31 -0400 Date: Mon, 21 Mar 2016 13:17:26 +0100 From: Carlos Maiolino To: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 2/9] dm: add methods to set and get reserved space Message-ID: <20160321121726.GC25476@redhat.com> References: <1458225037-24155-1-git-send-email-bfoster@redhat.com> <1458225037-24155-3-git-send-email-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458225037-24155-3-git-send-email-bfoster@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > +static int dm_blk_reserve_space(struct block_device *bdev, sector_t nr_sects) > +{ > + > +static int dm_blk_get_reserved_space(struct block_device *bdev, > + sector_t *nr_sects) > +{ These two functions are almost identical, what about refactoring it to a single function like dm_blk_reserved_space(), and maybe adding a flags argument, for choosing between set/get reserved space? Or maybe just add the common parts of these two functions inside a helper function or a macro?! -- Carlos