From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:49621 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756330AbcCUXo1 (ORCPT ); Mon, 21 Mar 2016 19:44:27 -0400 Date: Mon, 21 Mar 2016 13:25:48 -0400 From: Matthew Wilcox To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, NeilBrown , "Wilcox, Matthew R" Subject: Re: [PATCH 01/10] DAX: move RADIX_DAX_ definitions to dax.c Message-ID: <20160321172548.GN23727@linux.intel.com> References: <1458566575-28063-1-git-send-email-jack@suse.cz> <1458566575-28063-2-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458566575-28063-2-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Mar 21, 2016 at 02:22:46PM +0100, Jan Kara wrote: > These don't belong in radix-tree.c any more than PAGECACHE_TAG_* do. > Let's try to maintain the idea that radix-tree simply implements an > abstract data type. > > Signed-off-by: NeilBrown > Signed-off-by: Jan Kara Reviewed-by: Matthew Wilcox