From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
Date: Tue, 22 Mar 2016 13:41:13 +0300 [thread overview]
Message-ID: <20160322104113.GA143214@black.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1603211229060.26653@east.gentwo.org>
On Mon, Mar 21, 2016 at 12:29:34PM -0500, Christoph Lameter wrote:
> On Mon, 21 Mar 2016, Kirill A. Shutemov wrote:
>
> > We do have two page sizes in the page cache. It's the only option to get
> > transparent huge pages transparent.
>
> Should then not PAGE_CACHE_SIZE take a page parameter and return the
> correct page size?
Why? What would you achieve by this?
We already have a way to find out size of page: compoun_order() or
hpage_nr_pages().
And not in every place where PAGE_CACHE_SIZE is used we have corresponding
struct page.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-22 10:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 12:06 [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros Kirill A. Shutemov
2016-03-21 12:06 ` [PATCH 1/3] mm, fs: " Kirill A. Shutemov
2016-03-21 12:45 ` Michal Hocko
2016-03-21 17:02 ` Linus Torvalds
2016-03-21 17:07 ` Kirill A. Shutemov
2016-03-21 12:06 ` [PATCH 2/3] mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage Kirill A. Shutemov
2016-03-21 12:51 ` Michal Hocko
2016-03-21 12:06 ` [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition Kirill A. Shutemov
2016-03-21 12:53 ` Michal Hocko
2016-03-21 16:25 ` [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros Christoph Lameter
2016-03-21 16:34 ` Kirill A. Shutemov
2016-03-21 16:59 ` Christoph Lameter
2016-03-21 17:06 ` Kirill A. Shutemov
2016-03-21 17:29 ` Christoph Lameter
2016-03-22 10:41 ` Kirill A. Shutemov [this message]
2016-03-22 15:20 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322104113.GA143214@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).