From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:17642 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758758AbcCVLjU (ORCPT ); Tue, 22 Mar 2016 07:39:20 -0400 Date: Tue, 22 Mar 2016 14:38:49 +0300 From: Dan Carpenter To: Alexander Viro , Dan Williams Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] dax: silence an uninitialized variable warning Message-ID: <20160322113848.GA4519@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: I'm not positive, but it looks like it might be possible to reach the end of this function and return an uninitialized value for "rc". Anyway it causes a static checker warning and let's silence it. The warning was introduced in commit b2e0d1625e19 ('dax: fix lifetime of in-kernel dax mappings with dax_map_atomic()'). Signed-off-by: Dan Carpenter diff --git a/fs/dax.c b/fs/dax.c index 90322eb..3744e14 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -155,7 +155,8 @@ static ssize_t dax_io(struct inode *inode, struct iov_iter *iter, loff_t pos = start, max = start, bh_max = start; bool hole = false, need_wmb = false; struct block_device *bdev = NULL; - int rw = iov_iter_rw(iter), rc; + int rc = 0; + int rw = iov_iter_rw(iter); long map_len = 0; struct blk_dax_ctl dax = { .addr = (void __pmem *) ERR_PTR(-EIO),