From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:59242 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbcCXMcX (ORCPT ); Thu, 24 Mar 2016 08:32:23 -0400 Date: Thu, 24 Mar 2016 13:32:51 +0100 From: Jan Kara To: Ross Zwisler Cc: Jan Kara , linux-fsdevel@vger.kernel.org, "Wilcox, Matthew R" , Dan Williams , linux-nvdimm@lists.01.org, NeilBrown Subject: Re: [PATCH 03/10] dax: Remove complete_unwritten argument Message-ID: <20160324123251.GG4025@quack.suse.cz> References: <1458566575-28063-1-git-send-email-jack@suse.cz> <1458566575-28063-4-git-send-email-jack@suse.cz> <20160323171226.GB5544@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160323171226.GB5544@linux.intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 23-03-16 11:12:26, Ross Zwisler wrote: > On Mon, Mar 21, 2016 at 02:22:48PM +0100, Jan Kara wrote: > > Fault handlers currently take complete_unwritten argument to convert > > unwritten extents after PTEs are updated. However no filesystem uses > > this anymore as the code is racy. Remove the unused argument. > > This looks good. Looking at this reminded me that at some point it may be > good to clean up our buffer head flags checks and make sure we don't have > checks that don't make sense - we still check for buffer_unwritten() in > buffer_written(), for instance. > > The handling of BH_New isn't consistent among filesystems, either - XFS & ext4 > go out of their way to make sure BH_New is not set, while ext2 sets BH_New. > > But I think those are separate from this patch, I think. Yes, that's a separate thing and I think I've handled most of that in the following patches. Thanks for review! Honza -- Jan Kara SUSE Labs, CR