From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/vfs: improve __mnt_is_readonly
Date: Wed, 30 Mar 2016 09:23:10 +0800 [thread overview]
Message-ID: <20160330012310.GA3497@yaowei-K42JY> (raw)
In-Reply-To: <CAFLxGvyZ0eszz8CiTtd9U98b7Q2n_TDfV5A=jeb-jLu-Dt8Xdg@mail.gmail.com>
On Tue, Mar 29, 2016 at 11:43:21AM +0200, Richard Weinberger wrote:
> On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai
> <baiyaowei@cmss.chinamobile.com> wrote:
> > On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote:
> >> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote:
> >> > This patch refactors __mnt_is_readonly and makes it return bool to
> >> > improve readability due to this particular function only using either
> >> > one or zero as its return value.
> >>
> >> Improve in which way, if I may ask?
> >
> > A boolean return value can be more matchable with function's name and
> > more suitable as this function only returns 0/1.
>
> Please also think of the arguments made on linux-mtd[1].
> Hopping from one subsystem to another trying to sneak patches
> in is not the best idea... :-)
Acturally, this patch was sent before the mtd ones and all of them were sent
in one shot. You're really thinking too much.:-)
>
> [1]: http://lists.infradead.org/pipermail/linux-mtd/2016-March/066296.html
>
> --
> Thanks,
> //richard
next prev parent reply other threads:[~2016-03-30 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 2:01 [PATCH] fs/vfs: improve __mnt_is_readonly Yaowei Bai
2016-03-26 0:43 ` Al Viro
2016-03-29 6:35 ` Yaowei Bai
2016-03-29 9:43 ` Richard Weinberger
2016-03-30 1:23 ` Yaowei Bai [this message]
2016-03-30 7:30 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330012310.GA3497@yaowei-K42JY \
--to=baiyaowei@cmss.chinamobile.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox