linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Bob Peterson <rpeterso@redhat.com>,
	linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [vfs PATCH v3 1/4] VFS: move iomap from exportfs.h to iomap.h
Date: Tue, 29 Mar 2016 23:47:54 -0700	[thread overview]
Message-ID: <20160330064754.GA26251@infradead.org> (raw)
In-Reply-To: <20160329222036.GD30721@dastard>

On Wed, Mar 30, 2016 at 09:20:36AM +1100, Dave Chinner wrote:
> > For now I'm not sure the infrastructure will stay in the generic code or
> > in XFS, so for the first round I just wanted to ask for XFS feedback.
> 
> QA over the past couple of days has indicatedno regressions, so I'm
> going to seriously consider the multipage write code for the next
> XFS merge. I'd be happy to also take fiemap code based on the same
> iomap interfaces, especially if we can make it a generic, fully
> functional fiemap implementation and use it in XFS, too.

Ok.  Bob, is the code going to be useful for your in gfs2 as-is?  I'm
torn a bit between adding it to common code because it actually is
nicely abstracted and generic, and keepin it in XFS to make future
changes easier (getting rid of buffer_heads is the big one here)

  reply	other threads:[~2016-03-30  6:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 20:11 [vfs PATCH v3 0/4] vfs: Expand iomap interface to fiemap Bob Peterson
2016-03-04 20:11 ` [vfs PATCH v3 1/4] VFS: move iomap from exportfs.h to iomap.h Bob Peterson
2016-03-15  7:29   ` Christoph Hellwig
2016-03-28 19:53     ` Bob Peterson
2016-03-29  7:40       ` Christoph Hellwig
2016-03-29 22:20         ` Dave Chinner
2016-03-30  6:47           ` Christoph Hellwig [this message]
2016-04-07 19:58             ` Bob Peterson
2016-04-07 20:42               ` Christoph Hellwig
2016-04-10 17:15           ` Christoph Hellwig
2016-04-11  6:17             ` Dave Chinner
2016-04-12 18:29               ` Christoph Hellwig
2016-04-13  0:22                 ` Dave Chinner
2016-03-04 20:11 ` [vfs PATCH v3 2/4] VFS: Add new __generic_iomap_fiemap interface Bob Peterson
2016-03-07 10:18   ` Jan Kara
2016-03-15  7:33   ` Christoph Hellwig
2016-03-04 20:11 ` [vfs PATCH v3 3/4] GFS2: Add function gfs2_get_iomap Bob Peterson
2016-03-04 20:11 ` [vfs PATCH v3 4/4] GFS2: Use new iomap interface for fiemap Bob Peterson
2016-03-15  7:33   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330064754.GA26251@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).