From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: jack@suse.cz,
Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/5] Misc. cleanup and portability patches for quota-tools
Date: Wed, 30 Mar 2016 10:29:08 +0200 [thread overview]
Message-ID: <20160330082908.GE12776@quack.suse.cz> (raw)
In-Reply-To: <1459298887-21519-1-git-send-email-tytso@mit.edu>
Hi Ted,
On Tue 29-03-16 20:48:02, Ted Tso wrote:
> Here are some patches that provide some additional compatibility for
> quota-tools package.
>
> No, this isn't quite enough to allow quota-tools to build for
> Android/Bionic. These changes are sufficient to allow things to
> build, but there are still a few missing functions, most notably a
> syscall wrapper for quotactl(2), that are missing and which I'll add
> to a compatibility library in xfstests-bld, and/or get upstream into
> the Bionic libc at some point, if I can.
>
> I think these changes are generally useful, though. For example, with
> glibc on x86, if you try to do a build after configuring with
> --enable-rpc=no, the result is a huge number of build failures. This
> patch series will fix things so we can compile without rpc support.
Thanks for the fixes! I have merged them all. I had to slightly fix
nl_langinfo() checking so that HAVE_NL_LANGINFO is really defined in case
we have nl_langinfo() but it was easy enough.
I have also added explicit includes of stdlib.h into some files as
otherwise compilation without RPC emitted some warnings.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2016-03-30 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 0:48 [PATCH 0/5] Misc. cleanup and portability patches for quota-tools Theodore Ts'o
2016-03-30 0:48 ` [PATCH 1/5] Update the gitignore file to ignore additional generated files Theodore Ts'o
2016-03-30 0:48 ` [PATCH 2/5] Allow building on systems that do not have rpc header files Theodore Ts'o
2016-03-30 0:48 ` [PATCH 3/5] Use NGROUPS_MAX instead of NGROUPS Theodore Ts'o
2016-03-30 0:48 ` [PATCH 4/5] Provide fallback definitions for MNTTYPE_NFS and MNTTYPE_NOAUTO Theodore Ts'o
2016-03-30 0:48 ` [PATCH 5/5] Support systems which do not have nl_langinfo() Theodore Ts'o
2016-03-30 8:29 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330082908.GE12776@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).