linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Christoph Hellwig <hch@infradead.org>,
	xfs@oss.sgi.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	linux-api@vger.kernel.org
Subject: Re: fallocate mode flag for "unshare blocks"?
Date: Thu, 31 Mar 2016 00:55:29 -0700	[thread overview]
Message-ID: <20160331075529.GB4209@infradead.org> (raw)
In-Reply-To: <20160331003242.GA5813@localhost.localdomain>

On Wed, Mar 30, 2016 at 05:32:42PM -0700, Liu Bo wrote:
> Well, btrfs fallocate doesn't allocate space if it's a shared one
> because it thinks the space is already allocated.  So a later overwrite
> over this shared extent may hit enospc errors.

And this makes it an incorrect implementation of posix_fallocate,
which glibcs implements using fallocate if available.

  reply	other threads:[~2016-03-31  7:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160302155007.GB7125@infradead.org>
2016-03-30 18:27 ` fallocate mode flag for "unshare blocks"? Darrick J. Wong
2016-03-30 18:58   ` Austin S. Hemmelgarn
2016-03-31  7:58     ` Christoph Hellwig
2016-03-31 11:13       ` Austin S. Hemmelgarn
2016-03-31  0:32   ` Liu Bo
2016-03-31  7:55     ` Christoph Hellwig [this message]
2016-03-31 15:31       ` Andreas Dilger
2016-03-31 15:43         ` Austin S. Hemmelgarn
2016-03-31 16:47         ` Henk Slager
2016-03-31 11:18     ` Austin S. Hemmelgarn
2016-03-31 11:38       ` Austin S. Hemmelgarn
2016-03-31 19:52       ` Liu Bo
2016-03-31  1:18   ` Dave Chinner
2016-03-31  7:54     ` Christoph Hellwig
2016-03-31 11:18       ` Dave Chinner
2016-03-31 18:08         ` J. Bruce Fields
2016-03-31 18:19           ` Darrick J. Wong
2016-03-31 19:47           ` Andreas Dilger
2016-03-31 22:20             ` Dave Chinner
2016-03-31 22:34               ` J. Bruce Fields
2016-04-01  0:33                 ` Dave Chinner
2016-04-01  2:00                   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331075529.GB4209@infradead.org \
    --to=hch@infradead.org \
    --cc=bo.li.liu@oracle.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).