linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Martin Brandenburg <martin@omnibond.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] orangefs bugfixes for rc2
Date: Thu, 31 Mar 2016 21:19:49 -0400	[thread overview]
Message-ID: <20160401011949.GA29897@thunk.org> (raw)
In-Reply-To: <CAOg9mSTP0dnUQYpYcjwkqs+x0mC6o3zx7nq-OT5J=FeDJJ1Q-Q@mail.gmail.com>

On Thu, Mar 31, 2016 at 05:01:47PM -0400, Mike Marshall wrote:
> 
> but from our kernel.org tree... pull requests for reviewed code
> from kernel.org doesn't need signed tags...

Signed tags are considered best practice, even if your git tree is
hosted on git.kernel.org.  One of the reasons for this is because even
after Linus merges your changes, someone can independently verify that
the changes came from you; they don't have to trust Linus or whatever
git server they happened to pull the tree from.  For example, try
running the command:

  git show --show-signature faeb20ecfa398b043c3224607f512c009c51653d

You'll see something like this:

commit faeb20ecfa398b043c3224607f512c009c51653d
merged tag 'ext4_for_linus'
gpg: Signature made Wed 16 Mar 2016 05:25:58 PM EDT
gpg:                using RSA key 0xF2F95956950D81A3
gpg: Good signature from "Theodore Ts'o <tytso@mit.edu>" [ultimate]
gpg:                 aka "Theodore Ts'o <tytso@debian.org>" [ultimate]
gpg:                 aka "Theodore Ts'o <tytso@google.com>" [ultimate]
Primary key fingerprint: 3AB0 57B7 E78D 945C 8C55  91FB D36F 769B C118 04F0
     Subkey fingerprint: 2B69 B954 DBFE 0879 2881  37C9 F2F9 5956 950D 81A3
Merge: 364e8dd 0304688
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Mar 17 16:31:18 2016 -0700

    Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
    
    Pull ext4 updates from Ted Ts'o:
     "Performance improvements in SEEK_DATA and xattr scalability
      improvements, plus a lot of clean ups and bug fixes"

So while a signed tag might not be _required_, it's definitely
preferred.

Cheers,

						- Ted

  parent reply	other threads:[~2016-04-01  1:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 16:17 [git pull] orangefs bugfixes for rc2 Martin Brandenburg
2016-03-31 19:27 ` Linus Torvalds
2016-03-31 21:01   ` Mike Marshall
2016-03-31 21:06     ` Mike Marshall
2016-03-31 22:11       ` Linus Torvalds
2016-03-31 22:59       ` Al Viro
2016-04-01  1:19     ` Theodore Ts'o [this message]
2016-04-01 19:49   ` Martin Brandenburg
2016-04-01 22:35     ` Linus Torvalds
2016-04-01 23:29       ` Mike Marshall
2016-04-01 23:23     ` Joe Perches
2016-04-02  1:32       ` Martin Brandenburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401011949.GA29897@thunk.org \
    --to=tytso@mit.edu \
    --cc=hubcap@omnibond.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@omnibond.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).