* [PATCH] repquota: use the same whitespace for quotaio_meta as quotaio_v2
@ 2016-04-04 4:35 Theodore Ts'o
2016-04-04 9:31 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2016-04-04 4:35 UTC (permalink / raw)
To: jack; +Cc: Linux Filesystem Development List, Theodore Ts'o
If a quota implementation does not have a report function, such as
quotaio_meta, print the same white spaces so that xfstests generic/235
doesn't fail. The extra white sapce makes it easier to read the
output, and consistency is a good thing in any case.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
repquota.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/repquota.c b/repquota.c
index 957dc8d..ea79fc8 100644
--- a/repquota.c
+++ b/repquota.c
@@ -400,9 +400,10 @@ static void report_it(struct quota_handle *h, int type)
if (h->qh_ops->scan_dquots(h, output) < 0)
return;
dump_cached_dquots(type);
- if (h->qh_ops->report && ofmt == QOF_DEFAULT) {
+ if (ofmt == QOF_DEFAULT) {
putchar('\n');
- h->qh_ops->report(h, flags & FL_VERBOSE);
+ if (h->qh_ops->report)
+ h->qh_ops->report(h, flags & FL_VERBOSE);
putchar('\n');
}
if (ofmt == QOF_XML)
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] repquota: use the same whitespace for quotaio_meta as quotaio_v2
2016-04-04 4:35 [PATCH] repquota: use the same whitespace for quotaio_meta as quotaio_v2 Theodore Ts'o
@ 2016-04-04 9:31 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2016-04-04 9:31 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: jack, Linux Filesystem Development List
On Mon 04-04-16 00:35:40, Ted Tso wrote:
> If a quota implementation does not have a report function, such as
> quotaio_meta, print the same white spaces so that xfstests generic/235
> doesn't fail. The extra white sapce makes it easier to read the
> output, and consistency is a good thing in any case.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Thanks. Makes sense. I have merged the patch.
Honza
> ---
> repquota.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/repquota.c b/repquota.c
> index 957dc8d..ea79fc8 100644
> --- a/repquota.c
> +++ b/repquota.c
> @@ -400,9 +400,10 @@ static void report_it(struct quota_handle *h, int type)
> if (h->qh_ops->scan_dquots(h, output) < 0)
> return;
> dump_cached_dquots(type);
> - if (h->qh_ops->report && ofmt == QOF_DEFAULT) {
> + if (ofmt == QOF_DEFAULT) {
> putchar('\n');
> - h->qh_ops->report(h, flags & FL_VERBOSE);
> + if (h->qh_ops->report)
> + h->qh_ops->report(h, flags & FL_VERBOSE);
> putchar('\n');
> }
> if (ofmt == QOF_XML)
> --
> 2.5.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-04 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-04 4:35 [PATCH] repquota: use the same whitespace for quotaio_meta as quotaio_v2 Theodore Ts'o
2016-04-04 9:31 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).