* Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]
[not found] <20160502184018.502e9e7c@canb.auug.org.au>
@ 2016-05-02 10:15 ` Sergey Senozhatsky
2016-05-02 10:33 ` Mateusz Guzik
0 siblings, 1 reply; 5+ messages in thread
From: Sergey Senozhatsky @ 2016-05-02 10:15 UTC (permalink / raw)
To: linux-fsdevel
Cc: Alexander Viro, Stephen Rothwell, linux-next, linux-kernel,
Sergey Senozhatsky
On (05/02/16 18:40), Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20160429
Hello,
[ 0.368791] ------------[ cut here ]------------
[ 0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
[ 0.368911] Modules linked in:
[ 0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.6.0-rc6-next-20160502-dbg-00005-gf58c9da-dirty #404
[ 0.369161] 0000000000000000 ffff880133067908 ffffffff811b8202 0000000000000000
[ 0.369371] 0000000000000000 ffff880133067948 ffffffff81039365 00000698e5dffe26
[ 0.369580] ffff880132c090c0 ffffffff81613680 ffff880132c040a0 ffff880132c08000
[ 0.369791] Call Trace:
[ 0.369846] [<ffffffff811b8202>] dump_stack+0x4d/0x63
[ 0.369904] [<ffffffff81039365>] __warn+0xb8/0xd3
[ 0.369962] [<ffffffff810393e6>] warn_slowpath_null+0x18/0x1a
[ 0.370021] [<ffffffff811012f6>] d_set_d_op+0x5e/0xcc
[ 0.370079] [<ffffffff8110d887>] simple_lookup+0x2e/0x45
[ 0.370137] [<ffffffff810f6fbf>] lookup_slow+0xdb/0x12d
[ 0.370197] [<ffffffff818915d0>] ? initrd_load+0x3f/0x3f
[ 0.370255] [<ffffffff810f86b6>] walk_component+0xc2/0x201
[ 0.370313] [<ffffffff810f7cec>] ? path_init+0x169/0x2a4
[ 0.370371] [<ffffffff810f9083>] path_lookupat+0x7e/0xff
[ 0.370429] [<ffffffff810f917c>] filename_lookup+0x78/0xd4
[ 0.370489] [<ffffffff8104f172>] ? atomic_notifier_call_chain+0xf/0x11
[ 0.370551] [<ffffffff81244346>] ? notify_update+0x29/0x2b
[ 0.370609] [<ffffffff81245d24>] ? vt_console_print+0x2f3/0x302
[ 0.370668] [<ffffffff810f74a9>] ? getname_flags+0x48/0x15a
[ 0.370726] [<ffffffff810fa525>] user_path_at_empty+0x32/0x38
[ 0.370785] [<ffffffff810fa525>] ? user_path_at_empty+0x32/0x38
[ 0.370845] [<ffffffff810f3432>] vfs_fstatat+0x4c/0x87
[ 0.370903] [<ffffffff810ad7ba>] ? get_page_from_freelist+0x567/0x6f1
[ 0.370963] [<ffffffff810f349e>] vfs_lstat+0x19/0x1b
[ 0.371021] [<ffffffff810f356d>] SyS_newlstat+0x15/0x2e
[ 0.371079] [<ffffffff811be1b3>] ? simple_strtoull+0x2c/0x48
[ 0.371138] [<ffffffff818917de>] clean_path+0x20/0x5e
[ 0.371196] [<ffffffff811be1d8>] ? simple_strtoul+0x9/0xb
[ 0.371254] [<ffffffff81891a5f>] ? parse_header+0x2d/0xda
[ 0.371313] [<ffffffff81892219>] do_name+0x75/0x27a
[ 0.371370] [<ffffffff81891705>] write_buffer+0x23/0x34
[ 0.371428] [<ffffffff8189174a>] flush_buffer+0x34/0x8c
[ 0.371487] [<ffffffff818ae483>] __gunzip+0x268/0x308
[ 0.371545] [<ffffffff818ae211>] ? decompress_method+0x66/0x66
[ 0.371604] [<ffffffff81891716>] ? write_buffer+0x34/0x34
[ 0.371662] [<ffffffff81890812>] ? set_debug_rodata+0x12/0x12
[ 0.371721] [<ffffffff818ae534>] gunzip+0x11/0x13
[ 0.371778] [<ffffffff818915d0>] ? initrd_load+0x3f/0x3f
[ 0.371837] [<ffffffff81891e81>] unpack_to_rootfs+0x13b/0x257
[ 0.371896] [<ffffffff818915d0>] ? initrd_load+0x3f/0x3f
[ 0.371954] [<ffffffff818920a1>] ? maybe_link.part.2+0x104/0x104
[ 0.372013] [<ffffffff818920b9>] populate_rootfs+0x18/0x103
[ 0.372072] [<ffffffff818920a1>] ? maybe_link.part.2+0x104/0x104
[ 0.372132] [<ffffffff81000417>] do_one_initcall+0x8b/0x10e
[ 0.372191] [<ffffffff81890812>] ? set_debug_rodata+0x12/0x12
[ 0.372250] [<ffffffff81890f6c>] kernel_init_freeable+0x11e/0x1a6
[ 0.372311] [<ffffffff8144293f>] kernel_init+0x9/0xeb
[ 0.372369] [<ffffffff81446c92>] ret_from_fork+0x22/0x40
[ 0.372428] [<ffffffff81442936>] ? rest_init+0x7d/0x7d
[ 0.372503] ---[ end trace ce49db5ed97cc037 ]---
[ 0.372589] Unpacking initramfs...
-ss
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]
2016-05-02 10:15 ` linux-next: Tree for May 2 [WARNING: at fs/dcache.c] Sergey Senozhatsky
@ 2016-05-02 10:33 ` Mateusz Guzik
2016-05-02 12:07 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Mateusz Guzik @ 2016-05-02 10:33 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: linux-fsdevel, Alexander Viro, Stephen Rothwell, linux-next,
linux-kernel, Sergey Senozhatsky
On Mon, May 02, 2016 at 07:15:24PM +0900, Sergey Senozhatsky wrote:
> On (05/02/16 18:40), Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20160429
>
> Hello,
>
> [ 0.368791] ------------[ cut here ]------------
> [ 0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
> [ 0.368911] Modules linked in:
> [ 0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.6.0-rc6-next-20160502-dbg-00005-gf58c9da-dirty #404
> [ 0.369161] 0000000000000000 ffff880133067908 ffffffff811b8202 0000000000000000
> [ 0.369371] 0000000000000000 ffff880133067948 ffffffff81039365 00000698e5dffe26
> [ 0.369580] ffff880132c090c0 ffffffff81613680 ffff880132c040a0 ffff880132c08000
> [ 0.369791] Call Trace:
> [ 0.369846] [<ffffffff811b8202>] dump_stack+0x4d/0x63
> [ 0.369904] [<ffffffff81039365>] __warn+0xb8/0xd3
> [ 0.369962] [<ffffffff810393e6>] warn_slowpath_null+0x18/0x1a
> [ 0.370021] [<ffffffff811012f6>] d_set_d_op+0x5e/0xcc
> [ 0.370079] [<ffffffff8110d887>] simple_lookup+0x2e/0x45
The issue is that 2 macros have the same value:
#define DCACHE_OP_REAL 0x08000000
#define DCACHE_PAR_LOOKUP 0x08000000 /* being looked up
(with parent locked shared) */
Verified with switching one to 0x10000000 and the warning went away.
--
Mateusz Guzik
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]
2016-05-02 10:33 ` Mateusz Guzik
@ 2016-05-02 12:07 ` Stephen Rothwell
2016-05-02 12:35 ` Stephen Rothwell
2016-05-02 13:15 ` Sergey Senozhatsky
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2016-05-02 12:07 UTC (permalink / raw)
To: Mateusz Guzik
Cc: Sergey Senozhatsky, linux-fsdevel, Alexander Viro, linux-next,
linux-kernel, Sergey Senozhatsky, Theodore Ts'o,
Miklos Szeredi
Hi Mateusz,
On Mon, 2 May 2016 12:33:54 +0200 Mateusz Guzik <mguzik@redhat.com> wrote:
>
> On Mon, May 02, 2016 at 07:15:24PM +0900, Sergey Senozhatsky wrote:
> > On (05/02/16 18:40), Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20160429
> >
> > Hello,
> >
> > [ 0.368791] ------------[ cut here ]------------
> > [ 0.368850] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1688 d_set_d_op+0x5e/0xcc
> > [ 0.368911] Modules linked in:
> > [ 0.369002] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.6.0-rc6-next-20160502-dbg-00005-gf58c9da-dirty #404
> > [ 0.369161] 0000000000000000 ffff880133067908 ffffffff811b8202 0000000000000000
> > [ 0.369371] 0000000000000000 ffff880133067948 ffffffff81039365 00000698e5dffe26
> > [ 0.369580] ffff880132c090c0 ffffffff81613680 ffff880132c040a0 ffff880132c08000
> > [ 0.369791] Call Trace:
> > [ 0.369846] [<ffffffff811b8202>] dump_stack+0x4d/0x63
> > [ 0.369904] [<ffffffff81039365>] __warn+0xb8/0xd3
> > [ 0.369962] [<ffffffff810393e6>] warn_slowpath_null+0x18/0x1a
> > [ 0.370021] [<ffffffff811012f6>] d_set_d_op+0x5e/0xcc
> > [ 0.370079] [<ffffffff8110d887>] simple_lookup+0x2e/0x45
>
> The issue is that 2 macros have the same value:
>
> #define DCACHE_OP_REAL 0x08000000
>
> #define DCACHE_PAR_LOOKUP 0x08000000 /* being looked up
> (with parent locked shared) */
>
> Verified with switching one to 0x10000000 and the warning went away.
This comes from a bad automatic merge resolution between commit
d101a125954e ("fs: add file_dentry()")
from Linus' tree (introduced before v4.5-rc3) and commit
340450a54573 ("beginning of transition to parallel lookups - marking in-lookup dentries")
from the vfs tree.
I will fix this up in tomorrow's tree (unless Al beats me to it).
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]
2016-05-02 12:07 ` Stephen Rothwell
@ 2016-05-02 12:35 ` Stephen Rothwell
2016-05-02 13:15 ` Sergey Senozhatsky
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2016-05-02 12:35 UTC (permalink / raw)
To: Mateusz Guzik
Cc: Sergey Senozhatsky, linux-fsdevel, Alexander Viro, linux-next,
linux-kernel, Sergey Senozhatsky, Theodore Ts'o,
Miklos Szeredi
Hi all,
On Mon, 2 May 2016 22:07:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> This comes from a bad automatic merge resolution between commit
>
> d101a125954e ("fs: add file_dentry()")
>
> from Linus' tree (introduced before v4.5-rc3) and commit
^^^^^^^^
Clearly I typoed v4.6-rc3
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 2 [WARNING: at fs/dcache.c]
2016-05-02 12:07 ` Stephen Rothwell
2016-05-02 12:35 ` Stephen Rothwell
@ 2016-05-02 13:15 ` Sergey Senozhatsky
1 sibling, 0 replies; 5+ messages in thread
From: Sergey Senozhatsky @ 2016-05-02 13:15 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mateusz Guzik, Sergey Senozhatsky, linux-fsdevel, Alexander Viro,
linux-next, linux-kernel, Sergey Senozhatsky, Theodore Ts'o,
Miklos Szeredi
On (05/02/16 22:07), Stephen Rothwell wrote:
[..]
> > The issue is that 2 macros have the same value:
> >
> > #define DCACHE_OP_REAL 0x08000000
> >
> > #define DCACHE_PAR_LOOKUP 0x08000000 /* being looked up
> > (with parent locked shared) */
> >
> > Verified with switching one to 0x10000000 and the warning went away.
>
> This comes from a bad automatic merge resolution between commit
>
> d101a125954e ("fs: add file_dentry()")
>
> from Linus' tree (introduced before v4.5-rc3) and commit
>
> 340450a54573 ("beginning of transition to parallel lookups - marking in-lookup dentries")
>
> from the vfs tree.
>
> I will fix this up in tomorrow's tree (unless Al beats me to it).
good find, Mateusz.
thanks to both of you.
-ss
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-02 12:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160502184018.502e9e7c@canb.auug.org.au>
2016-05-02 10:15 ` linux-next: Tree for May 2 [WARNING: at fs/dcache.c] Sergey Senozhatsky
2016-05-02 10:33 ` Mateusz Guzik
2016-05-02 12:07 ` Stephen Rothwell
2016-05-02 12:35 ` Stephen Rothwell
2016-05-02 13:15 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).