From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:52284 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755674AbcEEOVs (ORCPT ); Thu, 5 May 2016 10:21:48 -0400 Date: Thu, 5 May 2016 07:21:44 -0700 From: Christoph Hellwig To: Toshi Kani Cc: dan.j.williams@intel.com, david@fromorbit.com, jack@suse.cz, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, micah.parrish@hpe.com, hch@infradead.org, adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, tytso@mit.edu Subject: Re: [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount Message-ID: <20160505142144.GA3601@infradead.org> References: <1462376761-15584-1-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462376761-15584-1-git-send-email-toshi.kani@hpe.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > if (mp->m_flags & XFS_MOUNT_DAX) { > + struct blk_dax_ctl dax = { > + .sector = 0, > + .size = PAGE_SIZE, > + }; I'm pretty sure I already complained last week, but this boiler plate code has no business in every file systems. Also it seems to me like this struct blk_dax_ctl calling convention is stupid to start with, why not pass the arguments directly and avoid the boilerplate code everywhere?