From: Jan Kara <jack@suse.cz>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com,
viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org,
boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca,
ross.zwisler@linux.intel.com, micah.parrish@hpe.com,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount
Date: Mon, 9 May 2016 10:31:25 +0200 [thread overview]
Message-ID: <20160509083125.GC11897@quack2.suse.cz> (raw)
In-Reply-To: <1462494596-20938-5-git-send-email-toshi.kani@hpe.com>
On Thu 05-05-16 18:29:55, Toshi Kani wrote:
> When a partition is not aligned by 4KB, mount -o dax succeeds,
> but any read/write access to the filesystem fails, except for
> metadata update.
>
> Call bdev_supports_dax() to perform proper precondition checks
> which includes this partition alignment check.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Boaz Harrosh <boaz@plexistor.com>
Looks good to me. Since this patch depends on the first two in your series,
just feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
and merge it along with other patches. I've removed the ext2 patch from
the previous version from my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-05-09 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 0:29 [PATCH v3 0/5] Add alignment check for DAX mount Toshi Kani
2016-05-06 0:29 ` [PATCH v3 1/5] block: Add vfs_msg() interface Toshi Kani
2016-05-08 8:56 ` Christoph Hellwig
2016-05-06 0:29 ` [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks Toshi Kani
2016-05-08 8:57 ` Christoph Hellwig
2016-05-08 19:14 ` Dan Williams
2016-05-09 18:12 ` Toshi Kani
2016-05-09 18:23 ` Dan Williams
2016-05-09 21:19 ` Dave Chinner
2016-05-09 22:34 ` Toshi Kani
2016-05-09 22:50 ` Toshi Kani
2016-05-06 0:29 ` [PATCH v3 3/5] ext4: Add alignment check for DAX mount Toshi Kani
2016-05-09 8:15 ` Jan Kara
2016-05-06 0:29 ` [PATCH v3 4/5] ext2: " Toshi Kani
2016-05-08 8:59 ` Christoph Hellwig
2016-05-09 8:23 ` Jan Kara
2016-05-09 8:31 ` Jan Kara [this message]
2016-05-06 0:29 ` [PATCH v3 5/5] xfs: " Toshi Kani
2016-05-08 8:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509083125.GC11897@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=micah.parrish@hpe.com \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).