From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Daniel Axtens <dja@axtens.net>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-kernel@vger.kernel.org, mpe@ellerman.id.au,
mszeredi@redhat.com, dchinner@redhat.com
Subject: Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker
Date: Tue, 17 May 2016 07:28:29 +0100 [thread overview]
Message-ID: <20160517062829.GG14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160516130727.GA26411@redhat.com>
On Mon, May 16, 2016 at 09:07:27AM -0400, Vivek Goyal wrote:
> So it became clear that we need a check at mount time to make sure
> d_type is supported otherwise error out. This will require users to
> do mkfs.xfs with ftype=1 to make progress.
>
> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
> not sure which version that change was made in.
Dumb question - can we end up with empty workdir at that point? Because
if we do, the check would appear to return a false negative, no matter
what fs supports...
next prev parent reply other threads:[~2016-05-17 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 6:45 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens
2016-05-16 13:07 ` Vivek Goyal
2016-05-17 6:28 ` Al Viro [this message]
2016-05-17 8:15 ` Miklos Szeredi
2016-05-17 12:10 ` Vivek Goyal
2016-05-17 14:24 ` Miklos Szeredi
2016-05-18 3:33 ` Daniel Axtens
2016-05-17 22:39 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517062829.GG14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dchinner@redhat.com \
--cc=dja@axtens.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mszeredi@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).