* pwrite04 ltp bug?
@ 2016-05-20 20:51 Mike Marshall
2016-05-21 11:43 ` Eryu Guan
0 siblings, 1 reply; 2+ messages in thread
From: Mike Marshall @ 2016-05-20 20:51 UTC (permalink / raw)
To: linux-fsdevel, Mike Marshall
Hi everyone...
While fixing a couple of LTP regressions in the out-of-tree Orangefs
kernel module, I think I found a problem with the pwrite04 test,
here's what I think was meant:
# git diff testcases/kernel/syscalls/pwrite/pwrite04.c
diff --git a/testcases/kernel/syscalls/pwrite/pwrite04.c
b/testcases/kernel/syscalls/pwrite/pwrite04.c
index b297682..4ca7dc1 100644
--- a/testcases/kernel/syscalls/pwrite/pwrite04.c
+++ b/testcases/kernel/syscalls/pwrite/pwrite04.c
@@ -196,9 +196,9 @@ int main(int ac, char *av[])
}
if (statbuf.st_size != K5) {
- tst_resm(TFAIL, "file size is %ld != K4",
+ tst_resm(TFAIL, "file size is %ld != K5",
statbuf.st_size);
-
+ cleanup();
}
tst_resm(TPASS, "O_APPEND test passed.");
Should I even be talking about this here, or should I go find
the github maintainers of LTP and ask them about it?
-Mike
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: pwrite04 ltp bug?
2016-05-20 20:51 pwrite04 ltp bug? Mike Marshall
@ 2016-05-21 11:43 ` Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2016-05-21 11:43 UTC (permalink / raw)
To: Mike Marshall; +Cc: linux-fsdevel
On Fri, May 20, 2016 at 04:51:30PM -0400, Mike Marshall wrote:
> Hi everyone...
>
> While fixing a couple of LTP regressions in the out-of-tree Orangefs
> kernel module, I think I found a problem with the pwrite04 test,
> here's what I think was meant:
>
> # git diff testcases/kernel/syscalls/pwrite/pwrite04.c
> diff --git a/testcases/kernel/syscalls/pwrite/pwrite04.c
> b/testcases/kernel/syscalls/pwrite/pwrite04.c
> index b297682..4ca7dc1 100644
> --- a/testcases/kernel/syscalls/pwrite/pwrite04.c
> +++ b/testcases/kernel/syscalls/pwrite/pwrite04.c
> @@ -196,9 +196,9 @@ int main(int ac, char *av[])
>
> }
> if (statbuf.st_size != K5) {
> - tst_resm(TFAIL, "file size is %ld != K4",
> + tst_resm(TFAIL, "file size is %ld != K5",
> statbuf.st_size);
> -
> + cleanup();
> }
> tst_resm(TPASS, "O_APPEND test passed.");
>
> Should I even be talking about this here, or should I go find
> the github maintainers of LTP and ask them about it?
Can you please send a patch to ltp list (ltp@lists.linux.it)? That's
where ltp developments and discussions happen.
Thanks,
Eryu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-21 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 20:51 pwrite04 ltp bug? Mike Marshall
2016-05-21 11:43 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).