Re: [PATCH v2 01/18] xattr: Remove unnecessary NULL attribute name check

[Carlos Maiolino <cmaiolino@redhat.com>]

On Fri, May 20, 2016 at 01:14:18PM +0200, Andreas Gruenbacher wrote:
> When NULL is passed to one of the xattr system calls as the attribute
> name, copying that name from user space already fails with -EFAULT;
> xattr_resolve_name is never called with a NULL attribute name.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

Hi Andreas,

this patch looks invalid for me now, since patch aaf431b4f9 (also from you) has
been already applied.

Do you still plan to remove this if statement?

you replaced it in the above mentioned patch by:

return ERR_PTR(-EINVAL)


> ---
>  fs/xattr.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/xattr.c b/fs/xattr.c
> index b11945e..2476acc 100644
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -667,9 +667,6 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
>  {
>  	const struct xattr_handler *handler;
>  
> -	if (!*name)
> -		return NULL;
> -
>  	for_each_xattr_handler(handlers, handler) {
>  		const char *n;
>  
> -- 
> 2.5.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos