From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:48928 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753354AbcEZMtI (ORCPT ); Thu, 26 May 2016 08:49:08 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B462472670 for ; Thu, 26 May 2016 12:49:07 +0000 (UTC) Received: from redhat.com (vpn-53-40.rdu2.redhat.com [10.10.53.40]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4QCn3wg013855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 26 May 2016 08:49:06 -0400 Date: Thu, 26 May 2016 14:49:02 +0200 From: Carlos Maiolino To: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 01/18] xattr: Remove unnecessary NULL attribute name check Message-ID: <20160526124902.GB734@redhat.com> References: <1463742875-9836-1-git-send-email-agruenba@redhat.com> <1463742875-9836-2-git-send-email-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463742875-9836-2-git-send-email-agruenba@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 20, 2016 at 01:14:18PM +0200, Andreas Gruenbacher wrote: > When NULL is passed to one of the xattr system calls as the attribute > name, copying that name from user space already fails with -EFAULT; > xattr_resolve_name is never called with a NULL attribute name. > > Signed-off-by: Andreas Gruenbacher Hi Andreas, this patch looks invalid for me now, since patch aaf431b4f9 (also from you) has been already applied. Do you still plan to remove this if statement? you replaced it in the above mentioned patch by: return ERR_PTR(-EINVAL) > --- > fs/xattr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/xattr.c b/fs/xattr.c > index b11945e..2476acc 100644 > --- a/fs/xattr.c > +++ b/fs/xattr.c > @@ -667,9 +667,6 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name) > { > const struct xattr_handler *handler; > > - if (!*name) > - return NULL; > - > for_each_xattr_handler(handlers, handler) { > const char *n; > > -- > 2.5.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos