From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:44336 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754522AbcEZUFb (ORCPT ); Thu, 26 May 2016 16:05:31 -0400 Date: Thu, 26 May 2016 21:05:26 +0100 From: Al Viro To: Mike Marshall Cc: Andreas Gruenbacher , linux-fsdevel Subject: Re: [PATCH 1/3] orangefs: Remove useless defines Message-ID: <20160526200526.GL14480@ZenIV.linux.org.uk> References: <1464172174-29237-1-git-send-email-agruenba@redhat.com> <1464172174-29237-2-git-send-email-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 26, 2016 at 03:44:23PM -0400, Mike Marshall wrote: > Hi Andreas... > > I've looked over your patch series, and was about > to apply it and run some tests... but the first patch > "orangefs: Remove useless defines" won't apply. > > I received your patch series a day or so after I merged > our kernel.org tree up to 4.6, and at first I thought maybe > you'd composed your patch during the long spell when > the last commit in our tree was e56f49814250f4ca4b66ec7d3a71152846761d1b, > resulting in some kind of conflict, but that's not it. Now > that we're upstream, you're probably patching against > the "real" Linux tree anyhow... > > Here's where the fail happens: > > @@ -470,7 +470,7 @@ static int orangefs_xattr_get_default(const struct > xattr_handler *handler, > size_t size) > { > return orangefs_inode_getxattr(inode, > - ORANGEFS_XATTR_NAME_DEFAULT_PREFIX, > + "", > name, > buffer, > size); > > "return orangefs_inode_getxattr(inode," should be > "return orangefs_inode_getxattr(dentry->d_inode," > > I looked way back in time, and don't think it ever > was "inode" instead of "dentry->d_inode", or how > it could ever be. Mainline has ->getxattr() called with dentry and inode passed separately; moreover, dentry is *NOT* guaranteed to be already associated with the inode. See commit ce23e64 and, subsequently, b96809.