From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Date: Thu, 16 Jun 2016 09:02:40 +0200
From: Willy Tarreau <w@1wt.eu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andy Lutomirski <luto@kernel.org>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] fs: Improve and simplify copy_mount_options
Message-ID: <20160616070240.GA7302@1wt.eu>
References: <cover.1465871650.git.luto@kernel.org>
 <f2ad616567c7666cbba22f51c97fac1d09cfd200.1465871650.git.luto@kernel.org>
 <20160615235047.GA14480@ZenIV.linux.org.uk>
 <CALCETrXie_5-Wz5o3aBxNCrDQwLmVyLHaa95S9YfTftpT5YtZA@mail.gmail.com>
 <CA+55aFy13+MYXU1tChx=Dysy_Ehhpc5Td+qrEaNv8smEygnuRQ@mail.gmail.com>
 <20160616054525.GA6803@1wt.eu>
 <CA+55aFwMpvtLbkMQqjA2FJa32FMuVX2Jtmevz9p=i8YOyKGZbA@mail.gmail.com>
 <20160616065738.GA7154@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160616065738.GA7154@1wt.eu>
Sender: stable-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jun 16, 2016 at 08:57:38AM +0200, Willy Tarreau wrote:
(...)
> +	/* avoid reading a whole page if the FS only needs a string. */
> +	if (!(type->fs_flags & FS_BINARY_MOUNTDATA)) {
> +		strlcpy(copy, data, PAGE_SIZE);

BTW, I forgot that we're first supposed to come from user, make that
strndup_user() instead.

Willy