From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:50137 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbcFQLcZ (ORCPT ); Fri, 17 Jun 2016 07:32:25 -0400 Date: Fri, 17 Jun 2016 04:32:23 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, xfs@oss.sgi.com Subject: Re: [PATCH 001/119] vfs: fix return type of ioctl_file_dedupe_range Message-ID: <20160617113223.GA19042@infradead.org> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612627940.12839.15145788608361492501.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146612627940.12839.15145788608361492501.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 16, 2016 at 06:17:59PM -0700, Darrick J. Wong wrote: > All the VFS functions in the dedupe ioctl path return int status, so > the ioctl handler ought to as well. > > Found by Coverity, CID 1350952. > > Signed-off-by: Darrick J. Wong This should go out to Al as a separate patch.