From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:50282 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbcFQLdP (ORCPT ); Fri, 17 Jun 2016 07:33:15 -0400 Date: Fri, 17 Jun 2016 04:33:14 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, xfs@oss.sgi.com Subject: Re: [PATCH 003/119] xfs: check offsets of variable length structures Message-ID: <20160617113314.GB19042@infradead.org> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612629195.12839.14090954204243398929.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146612629195.12839.14090954204243398929.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 16, 2016 at 06:18:12PM -0700, Darrick J. Wong wrote: > Some of the directory/attr structures contain variable-length objects, > so the enclosing structure doesn't have a meaningful fixed size at > compile time. We can check the offsets of the members before the > variable-length member, so do those. > > Signed-off-by: Darrick J. Wong Looks fine, and should go in independently of the rmap work: Reviewed-by: Christoph Hellwig