From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:50315 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbcFQLen (ORCPT ); Fri, 17 Jun 2016 07:34:43 -0400 Date: Fri, 17 Jun 2016 04:34:42 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, xfs@oss.sgi.com Subject: Re: [PATCH 005/119] xfs: check for a valid error_tag in errortag_add Message-ID: <20160617113442.GD19042@infradead.org> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612630452.12839.3528211000490660021.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146612630452.12839.3528211000490660021.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 16, 2016 at 06:18:24PM -0700, Darrick J. Wong wrote: > Currently we don't check the error_tag when someone's trying to set up > error injection testing. If userspace passes in a value we don't know > about, send back an error. This will help xfstests to _notrun a test > that uses error injection to test things like log replay. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig