From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:50139 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827AbcFUAs7 (ORCPT ); Mon, 20 Jun 2016 20:48:59 -0400 Date: Tue, 21 Jun 2016 10:48:30 +1000 From: Dave Chinner To: Christoph Hellwig Cc: "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, xfs@oss.sgi.com Subject: Re: [PATCH 008/119] xfs: separate freelist fixing into a separate helper Message-ID: <20160621004830.GM26977@dastard> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612632363.12839.15504324533944246285.stgit@birch.djwong.org> <20160617115204.GG19042@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617115204.GG19042@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jun 17, 2016 at 04:52:04AM -0700, Christoph Hellwig wrote: > > +/* Ensure that the freelist is at full capacity. */ > > +int > > +xfs_free_extent_fix_freelist( > > + struct xfs_trans *tp, > > + xfs_agnumber_t agno, > > + struct xfs_buf **agbp) > > { > > - xfs_alloc_arg_t args; > > - int error; > > + xfs_alloc_arg_t args; > > Use struct xfs_alloc_arg if you change this anyway. > > > + int error; > > > > - ASSERT(len != 0); > > memset(&args, 0, sizeof(xfs_alloc_arg_t)); > > Same here. > > > - if (args.agbno + len > > > - be32_to_cpu(XFS_BUF_TO_AGF(args.agbp)->agf_length)) { > > - error = -EFSCORRUPTED; > > - goto error0; > > - } > > + XFS_WANT_CORRUPTED_GOTO(mp, > > + agbno + len <= be32_to_cpu(XFS_BUF_TO_AGF(agbp)->agf_length), > > + err); > > This introduces an overly long line. > > But except for these nitpicks this looks fine: I'll clean them up on commit. -Dave. -- Dave Chinner david@fromorbit.com