From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f41.google.com ([209.85.218.41]:32832 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcFVTua (ORCPT ); Wed, 22 Jun 2016 15:50:30 -0400 Received: by mail-oi0-f41.google.com with SMTP id u201so38363101oie.0 for ; Wed, 22 Jun 2016 12:50:29 -0700 (PDT) Date: Wed, 22 Jun 2016 14:50:27 -0500 From: Seth Forshee To: "Eric W. Biederman" Cc: Linux Containers , linux-fsdevel@vger.kernel.org, Miklos Szeredi , James Bottomley , Djalal Harouni , "Serge E. Hallyn" , Andy Lutomirski Subject: Re: [PATCH review 13/13] userns: Remove the now unnecessary FS_USERNS_DEV_MOUNT flag Message-ID: <20160622195027.GH125285@ubuntu-hedt> References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-13-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160620172130.15712-13-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 20, 2016 at 12:21:30PM -0500, Eric W. Biederman wrote: > Now that SB_I_NODEV controls the nodev behavior devpts can just clear > this flag during mount. Simplifying the code and making it easier > to audit how the code works. While still preserving the invariant > that s_iflags is only modified during mount. > > Signed-off-by: "Eric W. Biederman" Acked-by: Seth Forshee