From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1050.oracle.com ([141.146.126.70]:47461 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbcF1Tdv (ORCPT ); Tue, 28 Jun 2016 15:33:51 -0400 Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by aserp1050.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u5SJKwdW026874 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Jun 2016 19:20:58 GMT Date: Tue, 28 Jun 2016 12:19:29 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, xfs@oss.sgi.com Subject: Re: [PATCH 001/119] vfs: fix return type of ioctl_file_dedupe_range Message-ID: <20160628191929.GC4917@birch.djwong.org> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612627940.12839.15145788608361492501.stgit@birch.djwong.org> <20160617113223.GA19042@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617113223.GA19042@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jun 17, 2016 at 04:32:23AM -0700, Christoph Hellwig wrote: > On Thu, Jun 16, 2016 at 06:17:59PM -0700, Darrick J. Wong wrote: > > All the VFS functions in the dedupe ioctl path return int status, so > > the ioctl handler ought to as well. > > > > Found by Coverity, CID 1350952. > > > > Signed-off-by: Darrick J. Wong > > This should go out to Al as a separate patch. I sent it to him back in February, though he hasn't responded. --D > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs