From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Ming Lei <ming.lei@canonical.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>
Subject: Re: Question about loop device DIO/AIO and FLUSH
Date: Fri, 1 Jul 2016 06:25:10 +0200 [thread overview]
Message-ID: <20160701042510.GA381@lst.de> (raw)
In-Reply-To: <CAOQ4uxhEzr=yaFPO4ZVzndct84VC6c57W5DNEtqUHUcBjdTjQg@mail.gmail.com>
On Thu, Jun 30, 2016 at 11:54:48PM +0300, Amir Goldstein wrote:
> Hi Ming,
>
> I was reading through the code of loop DIO/AIO
> and I was wondering whether lo_req_flush() really
> honors REQ_FLUSH by calling vfs_fsync() on a backing file
> that is open with O_DIRECT?
>
> Shouldn't lo_req_flush() actually wait for completion of
> all the in-flight loop AIO requests to complete?
> Am I missing something?
Both fsync and flush semanrics only apply to I/O requests that have already
completed.
next prev parent reply other threads:[~2016-07-01 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 20:54 Question about loop device DIO/AIO and FLUSH Amir Goldstein
2016-07-01 4:25 ` Christoph Hellwig [this message]
2016-07-01 5:00 ` Damien Le Moal
2016-07-01 5:04 ` Christoph Hellwig
2016-07-01 5:17 ` Damien Le Moal
2016-07-01 5:32 ` Christoph Hellwig
2016-07-01 5:35 ` Damien Le Moal
2016-07-01 6:57 ` Ming Lei
2016-07-03 8:26 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701042510.GA381@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).