From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:33239 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbcGDUNE (ORCPT ); Mon, 4 Jul 2016 16:13:04 -0400 Received: by mail-pa0-f49.google.com with SMTP id b13so61155716pat.0 for ; Mon, 04 Jul 2016 13:13:03 -0700 (PDT) Date: Mon, 4 Jul 2016 13:13:01 -0700 From: Omar Sandoval To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] vfs: fix typo in link_path_walk() Message-ID: <20160704201301.GA31238@vader> References: <1467650933-20089-1-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467650933-20089-1-git-send-email-luisbg@osg.samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote: > Comment documenting the path parsing in link_path_walk() has a typo, fixing > it. > > Signed-off-by: Luis de Bethencourt > --- > > Hello, > > Noticed this typo while studying the code paths when sys_open is called. > > Thanks, > Luis > > fs/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 32f9fe9..ade7667 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd) > if (!*name) > goto OK; > /* > - * If it wasn't NUL, we know it was '/'. Skip that > + * If it wasn't NULL, we know it was '/'. Skip that > * slash, and continue until no more slashes. > */ > do { > -- > 2.6.4 NUL is the ASCII '\0' character. NULL is a pointer. So NUL is correct. -- Omar