From: Al Viro <viro@ZenIV.linux.org.uk>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix typo in link_path_walk()
Date: Mon, 4 Jul 2016 21:50:38 +0100 [thread overview]
Message-ID: <20160704205038.GJ14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1467650933-20089-1-git-send-email-luisbg@osg.samsung.com>
On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote:
> Comment documenting the path parsing in link_path_walk() has a typo, fixing
> it.
> @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
> if (!*name)
> goto OK;
> /*
> - * If it wasn't NUL, we know it was '/'. Skip that
> + * If it wasn't NULL, we know it was '/'. Skip that
"If it wasn't <this>, we know it was <that>" really implies that <this> and
<that> are values possible for the same expression, doesn't it? How could
a pointer (NULL) and a character ('/') possibly be such?
Could you explain the meaning of thus "fixed" comment? I'm not even asking
to explain why it is correct that way, just what the hell is it supposed to
mean?
NAK, in case it's not obvious from the above...
next prev parent reply other threads:[~2016-07-04 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 16:48 [PATCH] vfs: fix typo in link_path_walk() Luis de Bethencourt
2016-07-04 20:13 ` Omar Sandoval
2016-07-04 20:50 ` Al Viro [this message]
2016-07-05 13:37 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704205038.GJ14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).