From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:55060 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753777AbcGDUul (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 4 Jul 2016 16:50:41 -0400
Date: Mon, 4 Jul 2016 21:50:38 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix typo in link_path_walk()
Message-ID: <20160704205038.GJ14480@ZenIV.linux.org.uk>
References: <1467650933-20089-1-git-send-email-luisbg@osg.samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467650933-20089-1-git-send-email-luisbg@osg.samsung.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote:
> Comment documenting the path parsing in link_path_walk() has a typo, fixing
> it.

> @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
>  		if (!*name)
>  			goto OK;
>  		/*
> -		 * If it wasn't NUL, we know it was '/'. Skip that
> +		 * If it wasn't NULL, we know it was '/'. Skip that

"If it wasn't <this>, we know it was <that>" really implies that <this> and
<that> are values possible for the same expression, doesn't it?  How could
a pointer (NULL) and a character ('/') possibly be such?

Could you explain the meaning of thus "fixed" comment?  I'm not even asking
to explain why it is correct that way, just what the hell is it supposed to
mean?

NAK, in case it's not obvious from the above...