From: Theodore Ts'o <tytso@mit.edu>
To: Chao Yu <chao@kernel.org>
Cc: jack@suse.cz, viro@zeniv.linux.org.uk,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chao Yu <yuchao0@huawei.com>
Subject: Re: mbcache: fix to detect failure of register_shrinker
Date: Tue, 5 Jul 2016 16:16:25 -0400 [thread overview]
Message-ID: <20160705201625.GA18568@thunk.org> (raw)
In-Reply-To: <1463411798-2597-1-git-send-email-chao@kernel.org>
On Mon, May 16, 2016 at 11:16:38PM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> register_shrinker in mb_cache_create may fail due to no memory. This
> patch fixes to do the check of return value of register_shrinker and
> handle the error case, otherwise mb_cache_create may return with no
> error, but losing the inner shrinker.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks. (Apologies for the delay; this patch slipped through
the cracks.)
- Ted
next prev parent reply other threads:[~2016-07-05 20:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 15:16 [PATCH] mbcache: fix to detect failure of register_shrinker Chao Yu
2016-05-16 15:31 ` Jan Kara
2016-07-05 20:16 ` Theodore Ts'o [this message]
2016-08-31 15:31 ` Chao Yu
2016-08-31 15:48 ` Theodore Ts'o
2016-08-31 16:19 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705201625.GA18568@thunk.org \
--to=tytso@mit.edu \
--cc=chao@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).