From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Jeff Layton <jlayton@redhat.com>,
Thorsten Leemhuis <regressions@leemhuis.info>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] posix_acl: de-union a_refcount and a_rcu
Date: Mon, 11 Jul 2016 18:49:56 +0100 [thread overview]
Message-ID: <20160711174956.GX14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFwng5Uk8PDgYPZMO8L4CL+A2P-1ZtribaR7FaU-nGrM6A@mail.gmail.com>
On Mon, Jul 11, 2016 at 09:50:21AM -0700, Linus Torvalds wrote:
> On Mon, Jul 11, 2016 at 8:01 AM, Andreas Gruenbacher
> <agruenba@redhat.com> wrote:
> > From: Jeff Layton <jlayton@redhat.com>
> >
> > Currently the two are unioned together, but I don't think that's safe.
>
> Ack. That does look fishy. Almost anything else can probably be
> unioned together with the rcu list, but *not* the refcount that we
> might want to look at during the rcu grace period.
>
> Al, this is your code (from long long ago). Want to take it through
> the vfs tree, or should I just apply direectly? I'd like to have your
> ack regardless, but the fix looks ObviouslyCorrect(tm) to me.
Applied; the mess had been caused by get_cached_acl() switch from ->i_lock
to rcu_read_lock. The code is mine, but relevant part is fairly recent.
I'll send a pull request tonight, with that thing included.
next prev parent reply other threads:[~2016-07-11 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 15:01 [PATCH] posix_acl: de-union a_refcount and a_rcu Andreas Gruenbacher
2016-07-11 16:50 ` Linus Torvalds
2016-07-11 17:08 ` Jeff Layton
2016-07-11 17:49 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-05 23:55 Jeff Layton
2016-07-07 14:11 ` David Howells
2016-07-07 14:20 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711174956.GX14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=agruenba@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).