From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:34696 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbcGLF01 (ORCPT ); Tue, 12 Jul 2016 01:26:27 -0400 Date: Tue, 12 Jul 2016 06:26:24 +0100 From: Al Viro To: David Chen Cc: lkml , linux-fsdevel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] vfs: check i_count under lock in evict_inodes Message-ID: <20160712052624.GC14480@ZenIV.linux.org.uk> References: <1468282504-2272-1-git-send-email-david.chen@osnexus.com> <20160712004623.GA14480@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 11, 2016 at 06:31:57PM -0700, David Chen wrote: > Hi Al, > > I'm not sure about the in-tree fs, but in zfsonlinux, it would offload > iput to a thread, so this would happen there. And it would wait for > the thread in put_super(), so that part is not a problem... *shrug* I hadn't looked (and won't look) at zfs glue, but I'd suggest trying something along the line of stopping that thread in the beginning of your ->kill_sb() (having told the sucker to stop offloading, of course) and only then calling generic_shutdown_super()...