From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: James Simmons <jsimmons@infradead.org>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send
Date: Fri, 15 Jul 2016 06:14:13 +0100 [thread overview]
Message-ID: <20160715051413.GI14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <72A3B3D7-69A3-40D4-8B89-103EB342E894@intel.com>
On Fri, Jul 15, 2016 at 01:01:35AM -0400, Oleg Drokin wrote:
> > + } else {
> > + iov_iter_kvec(&from, ITER_KVEC | WRITE,
> > + payload_iov, payload_niov,
> > + payload_nob + payload_offset);
> > + }
> > iov_iter_advance(&from, payload_offset);
>
> Ah, I guess we added it there to then subtract here?
Yes (and that actually fixes a real bug there).
> Do you mind if I just merge this change into Al's patch with you as another
> Signed-off-by line instead?
> Since we caught this early, probably no point in having a breakage point in
> the history as it might break a future bisect.
No objections from me. FWIW, I'd rather have all of that go through your
tree - it's independent from everything else in vfs.git and pulls quite
a bit from yours, so...
next prev parent reply other threads:[~2016-07-15 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 17:18 [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send James Simmons
2016-07-15 5:01 ` Oleg Drokin
2016-07-15 5:14 ` Al Viro [this message]
2016-07-18 15:23 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715051413.GI14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=andreas.dilger@intel.com \
--cc=jsimmons@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).