From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:38874 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751609AbcGOFOT (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 15 Jul 2016 01:14:19 -0400
Date: Fri, 15 Jul 2016 06:14:13 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: James Simmons <jsimmons@infradead.org>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send
Message-ID: <20160715051413.GI14480@ZenIV.linux.org.uk>
References: <1468257501-20630-1-git-send-email-jsimmons@infradead.org>
 <72A3B3D7-69A3-40D4-8B89-103EB342E894@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <72A3B3D7-69A3-40D4-8B89-103EB342E894@intel.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jul 15, 2016 at 01:01:35AM -0400, Oleg Drokin wrote:

> > +	} else {
> > +		iov_iter_kvec(&from, ITER_KVEC | WRITE,
> > +			      payload_iov, payload_niov,
> > +			      payload_nob + payload_offset);
> > +	}
> > 	iov_iter_advance(&from, payload_offset);
> 
> Ah, I guess we added it there to then subtract here?

Yes (and that actually fixes a real bug there).

> Do you mind if I just merge this change into Al's patch with you as another
> Signed-off-by line instead?
> Since we caught this early, probably no point in having a breakage point in
> the history as it might break a future bisect.

No objections from me.  FWIW, I'd rather have all of that go through your
tree - it's independent from everything else in vfs.git and pulls quite
a bit from yours, so...