From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:55384 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbcGRNel (ORCPT ); Mon, 18 Jul 2016 09:34:41 -0400 Date: Mon, 18 Jul 2016 09:34:39 -0400 From: Brian Foster To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, Dave Chinner , xfs@oss.sgi.com Subject: Re: [PATCH 049/119] xfs: enable the rmap btree functionality Message-ID: <20160718133439.GH27380@bfoster.bfoster> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612658581.12839.14068666392735480433.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146612658581.12839.14068666392735480433.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 16, 2016 at 06:23:05PM -0700, Darrick J. Wong wrote: > From: Dave Chinner > > Add the feature flag to the supported matrix so that the kernel can > mount and use rmap btree enabled filesystems > > v2: Move the EXPERIMENTAL message to fill_super so it only prints once. > > Signed-off-by: Dave Chinner > [darrick.wong@oracle.com: move the experimental tag] > Signed-off-by: Darrick J. Wong > --- Reviewed-by: Brian Foster > fs/xfs/libxfs/xfs_format.h | 3 ++- > fs/xfs/xfs_super.c | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > > diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h > index 6efc7a3..1b08237 100644 > --- a/fs/xfs/libxfs/xfs_format.h > +++ b/fs/xfs/libxfs/xfs_format.h > @@ -457,7 +457,8 @@ xfs_sb_has_compat_feature( > #define XFS_SB_FEAT_RO_COMPAT_FINOBT (1 << 0) /* free inode btree */ > #define XFS_SB_FEAT_RO_COMPAT_RMAPBT (1 << 1) /* reverse map btree */ > #define XFS_SB_FEAT_RO_COMPAT_ALL \ > - (XFS_SB_FEAT_RO_COMPAT_FINOBT) > + (XFS_SB_FEAT_RO_COMPAT_FINOBT | \ > + XFS_SB_FEAT_RO_COMPAT_RMAPBT) > #define XFS_SB_FEAT_RO_COMPAT_UNKNOWN ~XFS_SB_FEAT_RO_COMPAT_ALL > static inline bool > xfs_sb_has_ro_compat_feature( > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index a8300e4..9328821 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1571,6 +1571,10 @@ xfs_fs_fill_super( > xfs_alert(mp, > "EXPERIMENTAL sparse inode feature enabled. Use at your own risk!"); > > + if (xfs_sb_version_hasrmapbt(&mp->m_sb)) > + xfs_alert(mp, > + "EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!"); > + > error = xfs_mountfs(mp); > if (error) > goto out_filestream_unmount; > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs