From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 5/5] f2fs: use blk_plug in all the possible paths
Date: Mon, 18 Jul 2016 22:49:18 -0700 [thread overview]
Message-ID: <20160719054918.GB80986@jaegeuk> (raw)
In-Reply-To: <20160719035952.GB24437@infradead.org>
On Mon, Jul 18, 2016 at 08:59:52PM -0700, Christoph Hellwig wrote:
> On Thu, Jul 14, 2016 at 08:05:02PM -0700, Jaegeuk Kim wrote:
> > >From kernel guys working on android.
>
> Well, until it's mainline it simply doesn't matter, so NAK to this
> patch. Tying power behavior to plugs also sounds pretty broken, so we'd
> probably come up with something better if they bothered to actually
> submit their patches upsteam or at least explaining what they want
> to archive.
Actually, the initial patch which drops plugs is not mainlined as well.
So, at this time, I just want to revert it by this patch, since I recognized
that there might be whatever possible use-cases of plugs in another way someday.
So for now, I lost the reason to eliminate the plugs.
Moreover, since every filesystems use plugs, f2fs doesn't need to be an
exceptional case in terms of that (except hm-smr). So, let me sync f2fs
with other filesystems at this moment.
I totally agree that it'd be best to see their patches upstream, but I've
witnessed that it becomes a quite tough challenge to them.
Thanks,
prev parent reply other threads:[~2016-07-19 5:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 0:46 [PATCH 1/5] f2fs: refactor __exchange_data_block for speed up Jaegeuk Kim
2016-07-15 0:46 ` [PATCH 2/5] f2fs: disable extent_cache for fcollapse/finsert inodes Jaegeuk Kim
2016-07-15 0:46 ` [PATCH 3/5] f2fs: support copy_file_range Jaegeuk Kim
2016-07-15 0:46 ` [PATCH 4/5] f2fs: add maximum prefree segments Jaegeuk Kim
2016-07-15 0:46 ` [PATCH 5/5] f2fs: use blk_plug in all the possible paths Jaegeuk Kim
2016-07-15 2:21 ` Christoph Hellwig
2016-07-15 3:05 ` Jaegeuk Kim
2016-07-19 3:59 ` Christoph Hellwig
2016-07-19 5:49 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719054918.GB80986@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=hch@infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).