* [PATCH] fuse: fuse_flush must check mapping->flags for errors
@ 2016-07-20 1:07 Maxim Patlasov
0 siblings, 0 replies; only message in thread
From: Maxim Patlasov @ 2016-07-20 1:07 UTC (permalink / raw)
To: miklos; +Cc: linux-fsdevel, fuse-devel, devel, linux-kernel, kuznet
fuse_flush() calls write_inode_now() that triggers writeback, but actual
writeback will happen later, on fuse_sync_writes(). If an error happens,
fuse_writepage_end() will set error bit in mapping->flags. So, we have to
check mapping->flags after fuse_sync_writes().
Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
---
fs/fuse/file.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index ad1da83..b43401e 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -413,6 +413,15 @@ static int fuse_flush(struct file *file, fl_owner_t id)
if (err)
return err;
+ if (test_bit(AS_ENOSPC, &file->f_mapping->flags) &&
+ test_and_clear_bit(AS_ENOSPC, &file->f_mapping->flags))
+ err = -ENOSPC;
+ if (test_bit(AS_EIO, &file->f_mapping->flags) &&
+ test_and_clear_bit(AS_EIO, &file->f_mapping->flags))
+ err = -EIO;
+ if (err)
+ return err;
+
inode_lock(inode);
fuse_sync_writes(inode);
inode_unlock(inode);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-20 1:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-20 1:07 [PATCH] fuse: fuse_flush must check mapping->flags for errors Maxim Patlasov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).