From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:34027 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758525AbcG1AJK (ORCPT ); Wed, 27 Jul 2016 20:09:10 -0400 Date: Thu, 28 Jul 2016 01:09:03 +0100 From: Salah Triki To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] fs: befs: check silent flag before logging error Message-ID: <20160728000903.GC3942@pc> References: <1467232061-5600-1-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467232061-5600-1-git-send-email-luisbg@osg.samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jun 29, 2016 at 09:27:40PM +0100, Luis de Bethencourt wrote: > Log error only when silent flag is not set. > > Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors") > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > Reading the backlog of latest patches to befs, I noticed that Salah's patch > missed one call to befs_error() when setting all to only be used when the > silent argument is false. > > Thanks, > Luis > > fs/befs/linuxvfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index b700645..bf5658d 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -790,7 +790,8 @@ befs_fill_super(struct super_block *sb, void *data, int silent) > */ > blocksize = sb_min_blocksize(sb, 1024); > if (!blocksize) { > - befs_error(sb, "unable to set blocksize"); > + if (!silent) > + befs_error(sb, "unable to set blocksize"); > goto unacquire_priv_sbp; > } > > -- > 2.5.1 > Acked-by: Salah Triki regards, salah