linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <guaneryu@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	"supporter:XFS FILESYSTEM" <xfs@oss.sgi.com>,
	"open list:GFS2 FILE SYSTEM" <cluster-devel@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Bob Peterson <rpeterso@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode
Date: Tue, 2 Aug 2016 05:28:08 -0700	[thread overview]
Message-ID: <20160802122808.GF31492@infradead.org> (raw)
In-Reply-To: <1470139108-13115-1-git-send-email-guaneryu@gmail.com>

On Tue, Aug 02, 2016 at 07:58:28PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only a
> few places returning EACCES. I noticed this when running LTP on
> overlayfs, setxattr03 failed due to unexpected EACCES on immutable
> inode.
> 
> So converting all EACCES to EPERM on immutable inode.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Although maybe you'll have to split this into one patch per subsystems,
as otherwise no maintainer might be enticed to pick it up.

  reply	other threads:[~2016-08-02 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 11:58 [PATCH v2 RESEND] fs: return EPERM on immutable inode Eryu Guan
2016-08-02 12:28 ` Christoph Hellwig [this message]
2016-08-03 17:37 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802122808.GF31492@infradead.org \
    --to=hch@infradead.org \
    --cc=cluster-devel@redhat.com \
    --cc=guaneryu@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    --cc=swhiteho@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).