From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:44742 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbcHCCAo (ORCPT ); Tue, 2 Aug 2016 22:00:44 -0400 Date: Wed, 3 Aug 2016 12:00:39 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, bfoster@redhat.com, xfs@oss.sgi.com Subject: Re: [PATCH 36/47] xfs: convert unwritten status of reverse mappings Message-ID: <20160803020039.GR16044@dastard> References: <146907695530.25461.3225785294902719773.stgit@birch.djwong.org> <146907720267.25461.12865808398854547794.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146907720267.25461.12865808398854547794.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 20, 2016 at 10:00:02PM -0700, Darrick J. Wong wrote: > Provide a function to convert an unwritten extent to a real one and > vice versa. > > v2: Move unwritten bit to rm_offset. > > v3: Fix a bug where we touched the wrong btree_irec field due to a > stupid cut-and-paste error. > > Signed-off-by: Darrick J. Wong I've added a comment to the commit message that the algorithm and code structure has been derived from xfs_bmap_add_extent_unwritten_real(). It looks to be correct. -Dave. -- Dave Chinner david@fromorbit.com