From: Seth Forshee <seth.forshee@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel <fuse-devel@lists.sourceforge.net>,
linux-fsdevel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Michael j Theall" <mtheall@us.ibm.com>,
"Jean-Pierre André" <jean-pierre.andre@wanadoo.fr>,
"Nikolaus Rath" <Nikolaus@rath.org>
Subject: Re: [RFC v3 1/2] fuse: Use generic xattr ops
Date: Thu, 4 Aug 2016 09:12:50 -0500 [thread overview]
Message-ID: <20160804141250.GB28476@ubuntu-xps13> (raw)
In-Reply-To: <CAJfpegsLX9EbYL_Yb_QNTPpEXB8g6VQMu3hJYpFqMaoN4+VbjA@mail.gmail.com>
On Thu, Aug 04, 2016 at 01:09:58PM +0200, Miklos Szeredi wrote:
> > +const struct xattr_handler *fuse_xattr_handlers[] = {
> > + &fuse_xattr_handler,
>
> Please terminate array with NULL, despite the catch-all prefix. The
> less subtle the better.
Will do, thanks for the review.
Seth
next prev parent reply other threads:[~2016-08-04 14:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 21:27 [RFC v3 0/2] Support for posix acls in fuse Seth Forshee
2016-08-01 21:27 ` [RFC v3 1/2] fuse: Use generic xattr ops Seth Forshee
2016-08-04 11:09 ` Miklos Szeredi
2016-08-04 14:12 ` Seth Forshee [this message]
2016-08-01 21:27 ` [RFC v3 2/2] fuse: Add posix acl support Seth Forshee
2016-08-04 12:11 ` Miklos Szeredi
[not found] ` <CAJfpegtzeJid8tHkz66scDcpCjNEEwtBb4m8MQqq7u+SCdj3dQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-04 12:40 ` Ravishankar N
2016-08-04 14:11 ` Seth Forshee
2016-08-05 23:07 ` Eric W. Biederman
2016-08-06 1:52 ` Seth Forshee
2016-08-06 21:09 ` Miklos Szeredi
2016-08-07 3:46 ` Seth Forshee
2016-08-07 12:59 ` Eric W. Biederman
[not found] ` <87popkrazt.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-08-07 13:51 ` Seth Forshee
2016-08-16 20:59 ` Seth Forshee
2016-08-17 12:01 ` Miklos Szeredi
2016-08-01 23:03 ` [RFC v3 0/2] Support for posix acls in fuse Nikolaus Rath
2016-08-02 3:39 ` Seth Forshee
2016-08-02 15:13 ` [fuse-devel] " Michael Theall
2016-08-09 0:00 ` Nikolaus Rath
2016-08-09 0:03 ` Nikolaus Rath
2016-08-09 0:27 ` Eric W. Biederman
2016-08-09 22:44 ` Nikolaus Rath
2016-08-09 7:06 ` Jean-Pierre André
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804141250.GB28476@ubuntu-xps13 \
--to=seth.forshee@canonical.com \
--cc=Nikolaus@rath.org \
--cc=ebiederm@xmission.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=jean-pierre.andre@wanadoo.fr \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mtheall@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).