From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:33967 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbcHFVDN (ORCPT ); Sat, 6 Aug 2016 17:03:13 -0400 Date: Sat, 6 Aug 2016 19:36:38 +0100 From: Salah Triki To: Luis de Bethencourt Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] fs: befs: remove useless initialization to zero Message-ID: <20160806183638.GC3423@pc> References: <1fee3d0091bc23fa0c4fed25382f37270d290d44.1469997250.git.salah.triki@gmail.com> <579F5232.401@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <579F5232.401@osg.samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 01, 2016 at 02:44:18PM +0100, Luis de Bethencourt wrote: > On 31/07/16 21:34, Salah Triki wrote: > > node_off is unconditionally set to bt_super.root_node_ptr, so no need to > > init it to zero. > > > > Signed-off-by: Salah Triki > > --- > > fs/befs/btree.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > > index f33fc6c..3cb97e8 100644 > > --- a/fs/befs/btree.c > > +++ b/fs/befs/btree.c > > @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds, > > { > > struct befs_btree_node *this_node; > > befs_btree_super bt_super; > > - befs_off_t node_off = 0; > > + befs_off_t node_off; > > int cur_key; > > fs64 *valarray; > > char *keystart; > > > > Looks good to me. > > Strange that static analysis didn't pick this one up before. > > Acked-by: Luis de Bethencourt > > Pushed to the befs-next branch: > https://github.com/luisbg/linux-befs/tree/befs-next > > Thanks Salah, > Luis Thanx :) Salah