From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:36166 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbcHFUf1 (ORCPT ); Sat, 6 Aug 2016 16:35:27 -0400 Date: Sat, 6 Aug 2016 19:37:33 +0100 From: Salah Triki To: Luis de Bethencourt Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Message-ID: <20160806183732.GD3423@pc> References: <579F5691.4060200@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <579F5691.4060200@osg.samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 01, 2016 at 03:02:57PM +0100, Luis de Bethencourt wrote: > On 31/07/16 21:34, Salah Triki wrote: > > Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned > > value by this function is only used once. > > > > Signed-off-by: Salah Triki > > --- > > fs/befs/datastream.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c > > index b68b6f9..343123c 100644 > > --- a/fs/befs/datastream.c > > +++ b/fs/befs/datastream.c > > @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb, > > struct buffer_head *indir_block; > > befs_block_run indir_run; > > befs_disk_inode_addr *iaddr_array; > > - struct befs_sb_info *befs_sb = BEFS_SB(sb); > > > > befs_blocknr_t indir_start_blk = > > - data->max_indirect_range >> befs_sb->block_shift; > > + data->max_indirect_range >> BEFS_SB(sb)->block_shift; > > > > off_t dbl_indir_off = blockno - indir_start_blk; > > > > > > This looks to be consistent with other uses of BEFS_SB() when the value is > only used once. > > Thanks, > Luis > > Acked-by: Luis de Bethencourt > > Pushed to the befs-next branch: > https://github.com/luisbg/linux-befs/tree/befs-next Thanx :) salah