Re: [PATCH 2/6] fs: befs: remove in vain variable assignment

Luis de Bethencourt
2016-08-01T13:25:17Z

On 31/07/16 21:34, Salah Triki wrote:
> There is no need to set *value, it will be overwritten later.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> fs/befs/btree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> index a0e8cfa..f33fc6c 100644
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -348,8 +348,6 @@ befs_find_key(struct super_block *sb, struct befs_btree_node *node,
>
> befs_debug(sb, "---> %s %s", __func__, findkey);
>
> - *value = 0;
> -
> findkey_len = strlen(findkey);
>
> /* if node can not contain key, just skeep this node */
>

Hi Salah,

The key here is that befs_btree_find(), the only consumer of befs_find_key(),
doesn't use the value if the return is BEFS_BT_NOT_FOUND.

Tested the patch anyway to be sure.

Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next

Thanks!
Luis