Re: [PATCH 3/6] fs: befs: remove useless initialization to zero

Salah Triki
2016-08-06T21:03:13Z

On Mon, Aug 01, 2016 at 02:44:18PM +0100, Luis de Bethencourt wrote:
> On 31/07/16 21:34, Salah Triki wrote:
> > node_off is unconditionally set to bt_super.root_node_ptr, so no need to
> > init it to zero.
> >
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> > fs/befs/btree.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> > index f33fc6c..3cb97e8 100644
> > --- a/fs/befs/btree.c
> > +++ b/fs/befs/btree.c
> > @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
> > {
> > struct befs_btree_node *this_node;
> > befs_btree_super bt_super;
> > - befs_off_t node_off = 0;
> > + befs_off_t node_off;
> > int cur_key;
> > fs64 *valarray;
> > char *keystart;
> >
>
> Looks good to me.
>
> Strange that static analysis didn't pick this one up before.
>
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> Pushed to the befs-next branch:
> https://github.com/luisbg/linux-befs/tree/befs-next
>
> Thanks Salah,
> Luis

Thanx :)
Salah