From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:51745 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbcHIJff (ORCPT ); Tue, 9 Aug 2016 05:35:35 -0400 Date: Tue, 9 Aug 2016 02:35:31 -0700 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Al Viro , Miklos Szeredi , xfs@oss.sgi.com, "Yan, Zheng" , linux-fsdevel@vger.kernel.org, Ilya Dryomov , ceph-devel@vger.kernel.org Subject: Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok() Message-ID: <20160809093531.GA3937@infradead.org> References: <1470223689-17783-1-git-send-email-jack@suse.cz> <1470223689-17783-2-git-send-email-jack@suse.cz> <20160809082756.GA11657@infradead.org> <20160809093246.GB5107@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160809093246.GB5107@quack2.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Aug 09, 2016 at 11:32:46AM +0200, Jan Kara wrote: > So do you suggest xfs_iop_change_ok and xfs_iop_setattr_nonsize? I don't > really care, I just remember Dave had some ideas how names should be > consistent and this naming was his idea... Nah, just skip the prefix entirely, and maybe also already adopt to the new setattr_prepare naming. But if Dave already had an opinions let's just keep it as-is and sort the naming out later.