From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Tue, 23 Aug 2016 10:47:01 -0400
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Al Viro <viro@zeniv.linux.org.uk>,
        Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename()
Message-ID: <20160823144701.GA9798@kroah.com>
References: <1471961132-1675-1-git-send-email-mszeredi@redhat.com>
 <1471961132-1675-4-git-send-email-mszeredi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1471961132-1675-4-git-send-email-mszeredi@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Aug 23, 2016 at 04:05:28PM +0200, Miklos Szeredi wrote:
> This is trivial to do:
> 
>  - add flags argument to simple_rename()
>  - check if flags doesn't have any other than RENAME_NOREPLACE
>  - assign simple_rename() to .rename2 instead of .rename
> 
> Filesystems converted:
> 
> hugetlbfs, ramfs, bpf.
> 
> Debugfs uses simple_rename() to implement debugfs_rename(), which is for
> debugfs instances to rename files internally, not for userspace filesystem
> access.  For this case pass zero flags to simple_rename().
> 
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>